Fix attachment editing and return URLs

core/views.py

@@ -157,6 +157,14 @@ def parse_due_at_from_post(post):
         return None
 
 
+def delete_selected_attachments(item, attachment_ids):
+    for attachment in item.attachments.filter(pk__in=attachment_ids):
+        attachment.file.delete(save=False)
+        attachment.delete()
+    if hasattr(item, '_prefetched_objects_cache'):
+        item._prefetched_objects_cache.pop('attachments', None)
+
+
 def attach_files_and_replace_tokens(item, files):
     replacements = {}
     attached = False
@@ -1013,6 +1021,7 @@ def edit_item(request, pk):
             item.visibility, item.team = target_visibility, target_team
             item.save()
             form.save_m2m()
+            delete_selected_attachments(item, request.POST.getlist('delete_attachments'))
             attach_files_and_replace_tokens(item, request.FILES.getlist('files'))
             item.sync_metadata()
             apply_team_from_tags(item, request.user, force_private=item.visibility == Item.Visibility.PRIVATE)
@@ -1042,6 +1051,7 @@ def item_editor(request, pk):
             item.visibility, item.team = target_visibility, target_team
             item.save()
             form.save_m2m()
+            delete_selected_attachments(item, request.POST.getlist('delete_attachments'))
             attach_files_and_replace_tokens(item, request.FILES.getlist('files'))
             item.sync_metadata()
             apply_team_from_tags(item, request.user, force_private=item.visibility == Item.Visibility.PRIVATE)